Add a few new metadata variables in tempo for QC and BC #1597
Conversation
src/compo/tempo_nc2ioda.py
Outdated
| @@ -278,6 +296,9 @@ def _read(self): | |||
| self.outdata[('longitude', 'MetaData')] = lons[flg] | |||
| self.outdata[('quality_assurance_value', 'MetaData')] = qa_value[flg] | |||
| self.outdata[('cloud_fraction', 'MetaData')] = cld_fra[flg] | |||
| self.outdata[('solar_zenith_angle', 'MetaData')] = sza[flg] | |||
There was a problem hiding this comment.
are these the right IODA names? I thought snake case was frowned upon?
There was a problem hiding this comment.
thanks @CoryMartin-NOAA ,, you are correct the name to use is:
solarZenithAngle
note the first name in the list is the current standard with the other names ones that would be changed into the leading entry if the upgrader were run something like:
${JEDI_BUILD}/bin/ioda-upgrade-v2-to-v3.x ${ioda_v2} ${ioda_v3} ${JEDI_SRC}/ioda/share/ioda/yaml/validation/ObsSpace.yaml
…/ioda-converters into feature/tempo_sza
jeromebarre
added
the
needs review
|
@ashley314 there is no more version option in the TEMPO converter with that PR. We would need to update the EWOK and Skylab parts for the ingest suites. |
|
@jeromebarre Thanks, I'll take a look and open a ticket for the ingest suite. |
test/CMakeLists.txt
Outdated
| foreach (spec no2) #hcho not tested and o3 not out yet with real data | ||
| if (NOT (${spec} STREQUAL "hcho" AND (${coltype} STREQUAL "total" OR ${coltype} STREQUAL "stratosphere"))) | ||
| foreach (coltype total troposphere) | ||
| foreach (spec NO2) #hcho not tested and o3 not out yet with real data |
There was a problem hiding this comment.
Can you please make the indentation nicer?
Co-authored-by: Maryam Abdi <[email protected]>
|
I have addressed the review comments |
|
@ashley314 the PR now uniformize the the column options names. It uses |
Thank you, I made updates to update to |
Description
Add a few new metadata variables in tempo for QC and BC.
EDIT:
This PR now test TEMPO for V3 products. Previous version are deprecated and shouldn't be used. The version option has been removed.
The PR now adds solar zenith angle, viewing zenith angle and albedo with the correct convention format in metadata for both TropOMI and TEMPO products.
Those quantities will be most helpful for future bias correction.
Issue(s) addressed
Resolves #<issue_number>
Dependencies
List the other PRs that this PR is dependent on:
Impact
Expected impact on downstream repositories:
Checklist